Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2891)

Unified Diff: chrome/test/chromedriver/chrome/chrome_android_impl.cc

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_android_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_android_impl.cc b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
index 83c4213f9ae8709f067a49a16e3c7e444558aa89..1d34daf9912b3567de2d33df1d7b5ddba62ecac5 100644
--- a/chrome/test/chromedriver/chrome/chrome_android_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
@@ -9,6 +9,7 @@
#include "base/strings/string_split.h"
#include "chrome/test/chromedriver/chrome/device_manager.h"
#include "chrome/test/chromedriver/chrome/devtools_client.h"
+#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/chrome/devtools_http_client.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/net/port_server.h"
@@ -16,13 +17,14 @@
ChromeAndroidImpl::ChromeAndroidImpl(
std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
+ std::vector<std::unique_ptr<DevToolsEventListener>>
+ devtools_event_listeners,
std::unique_ptr<PortReservation> port_reservation,
std::string page_load_strategy,
std::unique_ptr<Device> device)
: ChromeImpl(std::move(http_client),
std::move(websocket_client),
- devtools_event_listeners,
+ std::move(devtools_event_listeners),
std::move(port_reservation),
page_load_strategy),
device_(std::move(device)) {}
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_android_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698