chrome/test/chromedriver/chrome/chrome_remote_impl.cc - Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_remote_impl.cc

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/chrome_remote_impl.cc

diff --git a/chrome/test/chromedriver/chrome/chrome_remote_impl.cc b/chrome/test/chromedriver/chrome/chrome_remote_impl.cc

index 5b9a669d29a1cb0e71f6b6697426fb33fd561609..9d320fcebb597a3ca51d234fdba7d9f8655a540f 100644

--- a/chrome/test/chromedriver/chrome/chrome_remote_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_remote_impl.cc

@@ -14,7 +14,8 @@

ChromeRemoteImpl::ChromeRemoteImpl(

std::unique_ptr<DevToolsHttpClient> http_client,

std::unique_ptr<DevToolsClient> websocket_client,

- ScopedVector<DevToolsEventListener>& devtools_event_listeners,

+ std::vector<std::unique_ptr<DevToolsEventListener>>&

+ devtools_event_listeners,

std::string page_load_strategy)

: ChromeImpl(std::move(http_client),

std::move(websocket_client),