Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: chrome/test/chromedriver/logging.h

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_CHROMEDRIVER_LOGGING_H_ 5 #ifndef CHROME_TEST_CHROMEDRIVER_LOGGING_H_
6 #define CHROME_TEST_CHROMEDRIVER_LOGGING_H_ 6 #define CHROME_TEST_CHROMEDRIVER_LOGGING_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
11 #include <vector>
11 12
12 #include "base/macros.h" 13 #include "base/macros.h"
13 #include "base/memory/scoped_vector.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "chrome/test/chromedriver/chrome/log.h" 15 #include "chrome/test/chromedriver/chrome/log.h"
16 16
17 struct Capabilities; 17 struct Capabilities;
18 class CommandListener; 18 class CommandListener;
19 class DevToolsEventListener; 19 class DevToolsEventListener;
20 class ListValue; 20 class ListValue;
21 struct Session; 21 struct Session;
22 class Status; 22 class Status;
23 23
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 std::deque<std::unique_ptr<base::ListValue>> batches_of_entries_; 76 std::deque<std::unique_ptr<base::ListValue>> batches_of_entries_;
77 77
78 DISALLOW_COPY_AND_ASSIGN(WebDriverLog); 78 DISALLOW_COPY_AND_ASSIGN(WebDriverLog);
79 }; 79 };
80 80
81 // Initializes logging system for ChromeDriver. Returns true on success. 81 // Initializes logging system for ChromeDriver. Returns true on success.
82 bool InitLogging(); 82 bool InitLogging();
83 83
84 // Creates |Log|s, |DevToolsEventListener|s, and |CommandListener|s based on 84 // Creates |Log|s, |DevToolsEventListener|s, and |CommandListener|s based on
85 // logging preferences. 85 // logging preferences.
86 Status CreateLogs(const Capabilities& capabilities, 86 Status CreateLogs(
87 const Session* session, 87 const Capabilities& capabilities,
88 ScopedVector<WebDriverLog>* out_logs, 88 const Session* session,
89 ScopedVector<DevToolsEventListener>* out_devtools_listeners, 89 std::vector<std::unique_ptr<WebDriverLog>>* out_logs,
90 ScopedVector<CommandListener>* out_command_listeners); 90 std::vector<std::unique_ptr<DevToolsEventListener>>* out_devtools_listeners,
91 std::vector<std::unique_ptr<CommandListener>>* out_command_listeners);
91 92
92 #endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_ 93 #endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698