Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/site_per_process_interactive_browsertest.cc

Issue 2777853004: Disable flaky SitePerProcessAutofillTest.PasswordAutofillPopupPositionInsideOOPIF (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/strings/string_number_conversions.h" 6 #include "base/strings/string_number_conversions.h"
7 #include "base/test/scoped_feature_list.h" 7 #include "base/test/scoped_feature_list.h"
8 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 8 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
9 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsert est_util.h" 9 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsert est_util.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 1227 matching lines...) Expand 10 before | Expand all | Expand 10 after
1238 bool observed_; 1238 bool observed_;
1239 gfx::Point focused_node_bounds_in_screen_; 1239 gfx::Point focused_node_bounds_in_screen_;
1240 scoped_refptr<content::MessageLoopRunner> loop_runner_; 1240 scoped_refptr<content::MessageLoopRunner> loop_runner_;
1241 1241
1242 DISALLOW_COPY_AND_ASSIGN(FocusedEditableNodeChangedObserver); 1242 DISALLOW_COPY_AND_ASSIGN(FocusedEditableNodeChangedObserver);
1243 }; 1243 };
1244 1244
1245 // This test verifies that displacements (margin, etc) in the position of an 1245 // This test verifies that displacements (margin, etc) in the position of an
1246 // OOPIF is considered when showing an AutofillClient warning pop-up for 1246 // OOPIF is considered when showing an AutofillClient warning pop-up for
1247 // unsecure web sites. 1247 // unsecure web sites.
1248 // Test is flaky. crbug.com/705914
1248 IN_PROC_BROWSER_TEST_F(SitePerProcessAutofillTest, 1249 IN_PROC_BROWSER_TEST_F(SitePerProcessAutofillTest,
1249 PasswordAutofillPopupPositionInsideOOPIF) { 1250 DISABLED_PasswordAutofillPopupPositionInsideOOPIF) {
1250 SetupMainTab(); 1251 SetupMainTab();
1251 ASSERT_TRUE( 1252 ASSERT_TRUE(
1252 base::FeatureList::IsEnabled(security_state::kHttpFormWarningFeature)); 1253 base::FeatureList::IsEnabled(security_state::kHttpFormWarningFeature));
1253 1254
1254 GURL main_url(embedded_test_server()->GetURL("a.com", "/iframe.html")); 1255 GURL main_url(embedded_test_server()->GetURL("a.com", "/iframe.html"));
1255 ui_test_utils::NavigateToURL(browser(), main_url); 1256 ui_test_utils::NavigateToURL(browser(), main_url);
1256 content::WebContents* active_web_contents = 1257 content::WebContents* active_web_contents =
1257 browser()->tab_strip_model()->GetActiveWebContents(); 1258 browser()->tab_strip_model()->GetActiveWebContents();
1258 1259
1259 // Add some displacement for <iframe>. 1260 // Add some displacement for <iframe>.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
1304 1305
1305 // Ideally, the length of the error vector should be 0.0f. But due to 1306 // Ideally, the length of the error vector should be 0.0f. But due to
1306 // potential rounding errors, we assume a larger limit (which is slightly 1307 // potential rounding errors, we assume a larger limit (which is slightly
1307 // larger than square root of 2). 1308 // larger than square root of 2).
1308 EXPECT_LT(error.Length(), 1.4143f) 1309 EXPECT_LT(error.Length(), 1.4143f)
1309 << "Origin of bounds from focused node changed event is '" 1310 << "Origin of bounds from focused node changed event is '"
1310 << focus_observer.focused_node_bounds_in_screen().ToString() 1311 << focus_observer.focused_node_bounds_in_screen().ToString()
1311 << "' but AutofillClient is reporting '" << bounds_origin.ToString() 1312 << "' but AutofillClient is reporting '" << bounds_origin.ToString()
1312 << "'"; 1313 << "'";
1313 } 1314 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698