Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2777783003: Record variable names in type inference cycles. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record variable names in type inference cycles. So, we will able to report them during checking. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dab346dd6ee45796b69cbaf800804908513c7ad3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +41 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-03-27 21:46:34 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-03-27 21:50:37 UTC) #2
scheglov
3 years, 8 months ago (2017-03-27 21:51:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dab346dd6ee45796b69cbaf800804908513c7ad3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698