Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3358)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java

Issue 2777773002: Show the image header for the Context Menu (Closed)
Patch Set: git rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
index 97229964c33f0daa7f4a437a5888e03dca8834dc..79e0f1ae0601085d4d303e533796a19f0ee260c2 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
@@ -61,7 +61,7 @@ public class TabularContextMenuUiTest extends ChromeActivityTestCaseBase<ChromeA
@SmallTest
@Feature({"CustomContextMenu"})
public void testViewDisplaysSingleItemProperly() throws ExecutionException {
- final TabularContextMenuUi dialog = new TabularContextMenuUi();
+ final TabularContextMenuUi dialog = new TabularContextMenuUi(new ContextMenuHelper());
final List<Pair<Integer, List<ContextMenuItem>>> itemGroups = new ArrayList<>();
List<ContextMenuItem> item = CollectionUtil.newArrayList(ContextMenuItem.ADD_TO_CONTACTS,
@@ -82,7 +82,7 @@ public class TabularContextMenuUiTest extends ChromeActivityTestCaseBase<ChromeA
@SmallTest
@Feature({"CustomContextMenu"})
public void testViewDisplaysViewPagerForMultipleItems() throws ExecutionException {
- final TabularContextMenuUi dialog = new TabularContextMenuUi();
+ final TabularContextMenuUi dialog = new TabularContextMenuUi(new ContextMenuHelper());
final List<Pair<Integer, List<ContextMenuItem>>> itemGroups = new ArrayList<>();
List<ContextMenuItem> item = CollectionUtil.newArrayList(ContextMenuItem.ADD_TO_CONTACTS,
@@ -104,7 +104,7 @@ public class TabularContextMenuUiTest extends ChromeActivityTestCaseBase<ChromeA
@SmallTest
@Feature({"CustomContextMenu"})
public void testURLIsShownOnContextMenu() throws ExecutionException {
- final TabularContextMenuUi dialog = new TabularContextMenuUi();
+ final TabularContextMenuUi dialog = new TabularContextMenuUi(new ContextMenuHelper());
final List<ContextMenuItem> item =
CollectionUtil.newArrayList(ContextMenuItem.ADD_TO_CONTACTS, ContextMenuItem.CALL,
ContextMenuItem.COPY_LINK_ADDRESS);
@@ -113,7 +113,7 @@ public class TabularContextMenuUiTest extends ChromeActivityTestCaseBase<ChromeA
@Override
public View call() {
return dialog.createContextMenuPageUi(
- getActivity(), new MockMenuParams(expectedUrl), item, item.size());
+ getActivity(), new MockMenuParams(expectedUrl), item, false, item.size());
}
});
@@ -124,7 +124,7 @@ public class TabularContextMenuUiTest extends ChromeActivityTestCaseBase<ChromeA
@SmallTest
@Feature({"CustomContextMenu"})
public void testHeaderIsNotShownWhenThereIsNoParams() throws ExecutionException {
- final TabularContextMenuUi dialog = new TabularContextMenuUi();
+ final TabularContextMenuUi dialog = new TabularContextMenuUi(new ContextMenuHelper());
final List<ContextMenuItem> item =
CollectionUtil.newArrayList(ContextMenuItem.ADD_TO_CONTACTS, ContextMenuItem.CALL,
ContextMenuItem.COPY_LINK_ADDRESS);
@@ -132,7 +132,7 @@ public class TabularContextMenuUiTest extends ChromeActivityTestCaseBase<ChromeA
@Override
public View call() {
return dialog.createContextMenuPageUi(
- getActivity(), new MockMenuParams(""), item, item.size());
+ getActivity(), new MockMenuParams(""), item, false, item.size());
}
});

Powered by Google App Engine
This is Rietveld 408576698