Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3673)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java

Issue 2777773002: Show the image header for the Context Menu (Closed)
Patch Set: Fixed based of tedchoc's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
index dbe631dda10b1e9ccec1db4dbea30d13b5186ee1..7d8a5745518b553d4362c1c18a4fd89575e2480b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
@@ -72,7 +72,10 @@ class TabularContextMenuListAdapter extends BaseAdapter {
Drawable icon = menuItem.getDrawableAndDescription(mContext);
viewHolder.mIcon.setImageDrawable(icon);
viewHolder.mIcon.setVisibility(icon != null ? View.VISIBLE : View.INVISIBLE);
-
+ viewHolder.mIcon.setOnClickListener(new View.OnClickListener() {
+ @Override
+ public void onClick(View view) {}
Ted C 2017/03/31 18:48:32 is this needed right now?
JJ 2017/03/31 19:01:20 Nope, sorry.
+ });
return convertView;
}

Powered by Google App Engine
This is Rietveld 408576698