Show the image header for the Context Menu

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.app.Dialog;
 import android.content.Context;
 import android.content.DialogInterface;
+import android.content.res.Resources;
+import android.graphics.Bitmap;
+import android.graphics.Canvas;
+import android.graphics.Shader;
+import android.graphics.drawable.BitmapDrawable;
+import android.graphics.drawable.Drawable;
 import android.support.design.widget.TabLayout;
 import android.support.v4.view.ViewPager;
 import android.support.v7.app.AlertDialog;
 import android.text.TextUtils;
 import android.util.Pair;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AdapterView;
 import android.widget.BaseAdapter;
+import android.widget.ImageView;
 import android.widget.ListView;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.Callback;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /**
  * A custom dialog that separates each group into separate tabs. It uses a dialog instead.
  */
 public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemClickListener {
     private Dialog mDialog;
     private Callback<Integer> mCallback;
     private int mMenuItemHeight;
+    private final ContextMenuHelper mContextMenuHelper;
+
+    /**
+     * A context menu that sperates types by tabs.
+     * @param contextMenuHelper The {@link ContextMenuHelper} is used to retrieve the thumbnail
+     *                          natively from the Context Menu Helper.
+     */
+    TabularContextMenuUi(ContextMenuHelper contextMenuHelper) {

[Ted C, 2017/03/31 16:19:33]

I don't think this class should take the ContextMenuHelper.  I think it should
just have the method onImageThumbnailReceived and the context menu helper should
kick of the image fetching and pass it in.  I want to keep the UI class devoid
of any direct native dependencies.

[JJ, 2017/03/31 18:43:59]

Done.

+        mContextMenuHelper = contextMenuHelper;
+    }
 
     @Override
     public void displayMenu(Context context, ContextMenuParams params,
             List<Pair<Integer, List<ContextMenuItem>>> items, Callback<Integer> onItemClicked,
             final Runnable onMenuShown, final Runnable onMenuClosed) {
         mCallback = onItemClicked;
         mDialog = createDialog(context, params, items);
         mDialog.getWindow().setBackgroundDrawable(ApiCompatibilityUtils.getDrawable(
                 context.getResources(), R.drawable.bg_find_toolbar_popup));
 
@@ skipping 28 matching lines @@
         dialog.setContentView(createPagerView(context, params, itemGroups));
         return dialog;
     }
 
     /**
      * Creates the view of a context menu. Based off the Context Type, it'll adjust the list of
      * items and display only the ones that'll be on that specific group.
      * @param context Used to get the resources of an item.
      * @param params used to create the header text.
      * @param items A set of Items to display in a context menu. Filtered based off the type.
-     * @return Returns a filled LinearLayout with all the context menu items
+     * @param isImage Whether or not the view should have an image layout or not.
+     * @param maxCount The maximum amount of {@link ContextMenuItem}s that could exist in this view
+     *                 or any other views calculated in the context menu. Used to estimate the size
+     *                 of the list.
+     * @return Returns a filled LinearLayout with all the context menu items.
      */
     @VisibleForTesting
-    ViewGroup createContextMenuPageUi(
-            Context context, ContextMenuParams params, List<ContextMenuItem> items, int maxCount) {
+    ViewGroup createContextMenuPageUi(Context context, ContextMenuParams params,
+            List<ContextMenuItem> items, boolean isImage, int maxCount) {
         ViewGroup baseLayout = (ViewGroup) LayoutInflater.from(context).inflate(
                 R.layout.tabular_context_menu_page, null);
         ListView listView = (ListView) baseLayout.findViewById(R.id.selectable_items);
-        displayHeaderIfVisibleItems(params, baseLayout);
+
+        if (isImage) {
+            displayImageHeader(baseLayout, params, context.getResources());
+        } else {
+            displayHeaderIfVisibleItems(params, baseLayout);
+        }
 
         // Set the list adapter and get the height to display it appropriately in a dialog.
         TabularContextMenuListAdapter listAdapter =
                 new TabularContextMenuListAdapter(items, context);
         ViewGroup.LayoutParams layoutParams = listView.getLayoutParams();
         layoutParams.height = measureApproximateListViewHeight(listView, listAdapter, maxCount);
         listView.setLayoutParams(layoutParams);
         listView.setAdapter(listAdapter);
         listView.setOnItemClickListener(this);
 
         return baseLayout;
     }
 
     private void displayHeaderIfVisibleItems(ContextMenuParams params, ViewGroup baseLayout) {
         String headerText = ChromeContextMenuPopulator.createHeaderText(params);
         final TextView headerTextView =
                 (TextView) baseLayout.findViewById(R.id.context_header_text);
         if (TextUtils.isEmpty(headerText)) {
+            baseLayout.findViewById(R.id.context_header_layout).setVisibility(View.GONE);
             headerTextView.setVisibility(View.GONE);
             baseLayout.findViewById(R.id.context_divider).setVisibility(View.GONE);
             return;
         }
         headerTextView.setVisibility(View.VISIBLE);
         headerTextView.setText(headerText);
         headerTextView.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
                 if (headerTextView.getMaxLines() == Integer.MAX_VALUE) {
                     headerTextView.setMaxLines(1);
                     headerTextView.setEllipsize(TextUtils.TruncateAt.END);
                 } else {
                     headerTextView.setMaxLines(Integer.MAX_VALUE);
                     headerTextView.setEllipsize(null);
                 }
             }
         });
     }
 
+    private void displayImageHeader(
+            ViewGroup baseLayout, ContextMenuParams params, Resources resources) {
+        displayHeaderIfVisibleItems(params, baseLayout);
+        // #displayHeaderIfVisibleItems() sets these two views to GONE if the header text is
+        // empty but they should still be visible because we have an image to display.
+        baseLayout.findViewById(R.id.context_header_layout).setVisibility(View.VISIBLE);
+        baseLayout.findViewById(R.id.context_divider).setVisibility(View.VISIBLE);
+
+        final ImageView imageView = (ImageView) baseLayout.findViewById(R.id.context_header_image);
+        TextView headerTextView = (TextView) baseLayout.findViewById(R.id.context_header_text);
+        // We'd prefer the header text is the title text instead of the link text for images.
+        String headerText = params.getTitleText();
+        if (!TextUtils.isEmpty(headerText)) {
+            headerTextView.setText(headerText);
+        }
+        setBackgroundForImageView(imageView, resources);
+        mContextMenuHelper.getThumbnail(new ContextMenuHelper.OnThumbnailReceivedListener() {
+            @Override
+            public void onThumbnailReceived(Bitmap bitmap) {
+                imageView.setImageBitmap(bitmap);
+            }
+        });
+    }
+
+    /**
+     * This creates a checkerboard style background displayed before the image is shown.
+     */
+    private void setBackgroundForImageView(ImageView imageView, Resources resources) {
+        Drawable drawable =
+                ApiCompatibilityUtils.getDrawable(resources, R.drawable.checkerboard_background);
+        Bitmap bitmap = Bitmap.createBitmap(drawable.getIntrinsicWidth(),
+                drawable.getIntrinsicHeight(), Bitmap.Config.ARGB_8888);
+        Canvas canvas = new Canvas(bitmap);
+        drawable.setBounds(0, 0, canvas.getWidth(), canvas.getHeight());
+        drawable.draw(canvas);
+        BitmapDrawable bm = new BitmapDrawable(resources, bitmap);
+        bm.setTileModeXY(Shader.TileMode.REPEAT, Shader.TileMode.REPEAT);
+        imageView.setVisibility(View.VISIBLE);
+        imageView.setBackground(bm);
+    }
+
     /**
      * To save time measuring the height, this method gets an item if the height has not been
      * previous measured and multiplies it by count of the total amount of items. It is fine if the
      * height too small as the ListView will scroll through the other values.
      * @param listView The ListView to measure the surrounding padding.
      * @param listAdapter The adapter which contains the items within the list.
      * @return Returns the combined height of the padding of the ListView and the approximate height
      *         of the ListView based off the an item.
      */
     private int measureApproximateListViewHeight(
@@ skipping 22 matching lines @@
         View view = LayoutInflater.from(context).inflate(R.layout.tabular_context_menu, null);
 
         List<Pair<String, ViewGroup>> viewGroups = new ArrayList<>();
         int maxCount = 0;
         for (int i = 0; i < itemGroups.size(); i++) {
             Pair<Integer, List<ContextMenuItem>> itemGroup = itemGroups.get(i);
             maxCount = Math.max(maxCount, itemGroup.second.size());
         }
         for (int i = 0; i < itemGroups.size(); i++) {
             Pair<Integer, List<ContextMenuItem>> itemGroup = itemGroups.get(i);
+            boolean isImage = itemGroup.first == R.string.contextmenu_image_title;

[Ted C, 2017/03/31 16:19:33]

Hmm...looking at this I think we might want to pass the ContextMenuGroup
identifier instead of the string resource id as that is probably what we should
be keying this off of.

Another TODO perhaps?

[JJ, 2017/03/31 18:43:59]

Added but I'd give a word of caution it's more of the fact that we're trying to
setup the image tab more than determining if it's an image.

             viewGroups.add(new Pair<>(context.getString(itemGroup.first),
-                    createContextMenuPageUi(context, params, itemGroup.second, maxCount)));
+                    createContextMenuPageUi(context, params, itemGroup.second, isImage, maxCount)));
         }
         TabularContextMenuViewPager pager =
                 (TabularContextMenuViewPager) view.findViewById(R.id.custom_pager);
         pager.setAdapter(new TabularContextMenuPagerAdapter(viewGroups));
 
         TabLayout tabLayout = (TabLayout) view.findViewById(R.id.tab_layout);
         if (itemGroups.size() <= 1) {
             tabLayout.setVisibility(View.GONE);
         }
         tabLayout.setupWithViewPager((ViewPager) view.findViewById(R.id.custom_pager));
 
         return view;
     }
 
     @Override
     public void onItemClick(AdapterView<?> adapterView, View view, int position, long id) {
         mDialog.dismiss();
         mCallback.onResult((int) id);
     }
 }