chrome/android/java/res/drawable/checkerboard_background.xml - Issue 2777773002: Show the image header for the Context Menu

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/checkerboard_background.xml

Issue 2777773002: Show the image header for the Context Menu (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/drawable/tabular_context_menu_image_border.xml » ('j') | chrome/android/java/res/drawable/tabular_context_menu_image_border.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->
	Theresa 2017/03/27 18:28:26 nit: add a blank line after the Copyright. nit: add a blank line after the Copyright. JJ 2017/03/27 20:47:12 Done. Show quoted text On 2017/03/27 18:28:26, Theresa wrote: > nit: add a blank line after the Copyright. Done.
	5 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">

	6 <item>

	7 <shape android:shape="rectangle">

	8 <solid android:color="#FFFFFF" />
	Theresa 2017/03/27 18:28:26 nit: @android:color/white nit: @android:color/white JJ 2017/03/27 20:47:12 Done. Show quoted text On 2017/03/27 18:28:26, Theresa wrote: > nit: @android:color/white Done.
	9 <size android:height="10dp" android:width="10dp"/>

	10 </shape>

	11 </item>

	12 <item android:top="0dp" android:left="10dp">

	13 <shape android:shape="rectangle">

	14 <solid android:color="#EEE"/>
	Theresa 2017/03/27 18:28:26 nit: Let's define this as google_grey_200 in color nit: Let's define this as google_grey_200 in colors.xml. JJ 2017/03/27 20:47:12 Done. Show quoted text On 2017/03/27 18:28:26, Theresa wrote: > nit: Let's define this as google_grey_200 in colors.xml. Done.
	15 <size android:height="10dp" android:width="10dp"/>

	16 </shape>

	17 </item>

	18 <item android:top="10dp" android:left="0dp">

	19 <shape android:shape="rectangle">

	20 <solid android:color="#EEE"/>

	21 <size android:height="10dp" android:width="10dp"/>

	22 </shape>

	23 </item>

	24 <item android:top="10dp" android:left="10dp">

	25 <shape android:shape="rectangle">

	26 <solid android:color="#FFFFFF" />

	27 <size android:height="10dp" android:width="10dp"/>

	28 </shape>

	29 </item>

	30 </layer-list>

OLD	NEW