Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp

Issue 2777763003: Bindings: Manage the main world separately from other worlds (Closed)
Patch Set: address review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp
index 1dc4a3639c3825a7516a35d9974e7286b4f46c44..1d7263738a6d9ebb0c57a92687471b47ec1d64d2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp
@@ -83,16 +83,11 @@ void workerThreadFunc(WorkerBackingThread* thread,
}
TEST(DOMWrapperWorldTest, Basic) {
- // Initially, there should be no worlds.
- EXPECT_FALSE(DOMWrapperWorld::nonMainWorldsExistInMainThread());
- Vector<RefPtr<DOMWrapperWorld>> retrievedWorlds;
- DOMWrapperWorld::allWorldsInCurrentThread(retrievedWorlds);
- EXPECT_TRUE(retrievedWorlds.isEmpty());
-
// Create the main world and verify it.
DOMWrapperWorld& mainWorld = DOMWrapperWorld::mainWorld();
EXPECT_TRUE(mainWorld.isMainWorld());
EXPECT_FALSE(DOMWrapperWorld::nonMainWorldsExistInMainThread());
+ Vector<RefPtr<DOMWrapperWorld>> retrievedWorlds;
DOMWrapperWorld::allWorldsInCurrentThread(retrievedWorlds);
EXPECT_EQ(1u, retrievedWorlds.size());
EXPECT_TRUE(retrievedWorlds[0]->isMainWorld());
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698