Add ImageSkiaRep::unscaled that tells if the image is for unscaled image.

Add ImageSkiaRep::unscaled that tells if the image is for unscaled image.

 Unscaled image only contains 1.0f image and used when it is the client responsibility to scale the image properly (Wallpaper for example)

 This is required for https://codereview.chromium.org/263253003/

BUG=None
TEST=covered by unit test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269660

[Jun Mukai, 2014-05-09 17:57:39]

https://codereview.chromium.org/277773002/diff/160001/ui/gfx/image/image_skia.cc
File ui/gfx/image/image_skia.cc (right):

https://codereview.chromium.org/277773002/diff/160001/ui/gfx/image/image_skia...
ui/gfx/image/image_skia.cc:258: return ImageSkia(ImageSkiaRep(bitmap, 0.0f));
Doesn't this cause any other unexpected results?
The caller might expect this as 'good for 1x and blurring scaled image for 2x'.

https://codereview.chromium.org/277773002/diff/160001/ui/gfx/image/image_skia...
ui/gfx/image/image_skia.cc:296: storage_->AddRepresentation(image_rep);
Why only this has to be replaced by AddRepresentation?  There's several other
image_reps().push_back().

[oshima, 2014-05-09 20:53:32]

https://codereview.chromium.org/277773002/diff/160001/ui/gfx/image/image_skia.cc
File ui/gfx/image/image_skia.cc (right):

https://codereview.chromium.org/277773002/diff/160001/ui/gfx/image/image_skia...
ui/gfx/image/image_skia.cc:258: return ImageSkia(ImageSkiaRep(bitmap, 0.0f));
On 2014/05/09 17:57:39, Jun Mukai wrote:
> Doesn't this cause any other unexpected results?
> The caller might expect this as 'good for 1x and blurring scaled image for
2x'.

Yes, this is exactly what I wanted to guarantee how this will work.

1.0f image gets scaled in canvas at drawing time right now,
and I want to keep the same behavior with your CL.

https://codereview.chromium.org/277773002/diff/160001/ui/gfx/image/image_skia...
ui/gfx/image/image_skia.cc:296: storage_->AddRepresentation(image_rep);
On 2014/05/09 17:57:39, Jun Mukai wrote:
> Why only this has to be replaced by AddRepresentation?  There's several other
> image_reps().push_back().

I added the comment to explain why.

[Jun Mukai, 2014-05-09 21:03:33]

lgtm

[oshima, 2014-05-09 21:17:27]

rsesek -> ui/base/resources

[Robert Sesek, 2014-05-09 21:25:17]

I don't think I own that directory, but LGTM anyways.

[oshima, 2014-05-09 21:39:52]

On 2014/05/09 21:25:17, rsesek wrote:
> I don't think I own that directory, but LGTM anyways.

oops sorry, I was confused by output of presubmit. thanks anyway.

[oshima, 2014-05-09 21:40:16]

tony -> ui/base/resources

[tony, 2014-05-09 21:48:03]

rubberstamp LGTM

[oshima, 2014-05-09 21:57:54]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-09 22:04:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/277773002/180001

[commit-bot: I haz the power, 2014-05-10 01:29:47]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-11 00:47:57]

Change committed as 269660