Add ScopedClipboardWriter::WriteData

Add ScopedClipboardWriter::WriteData

The WriteData function is needed for Chromium embedders (Electron, in
this case) who want to write arbitrary, non-Pickle data to the
clipboard.

BUG=

[poiru, 2017-03-25 21:13:58]

The CQ bit was checked by birunthan@mohanathas.com

[commit-bot: I haz the power, 2017-03-25 21:14:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 21:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 21:14:06]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[poiru, 2017-03-25 21:14:43]

Description was changed from

==========
Add ScopedClipboardWriter::WriteData

The WriteData function is needed for Chromium embedders (Electron, in
this case) who want to write arbitrary, non-Pickle data to the
clipboard.

BUG=
==========

to

==========
Add ScopedClipboardWriter::WriteData

The WriteData function is needed for Chromium embedders (Electron, in
this case) who want to write arbitrary, non-Pickle data to the
clipboard.

BUG=
==========

[poiru, 2017-03-25 21:14:43]

birunthan@mohanathas.com changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-04-05 08:40:39]

Btw, in the future, please explicitly send an email after adding a reviewer
(otherwise it's easy for the reviewer to miss)

https://codereview.chromium.org/2777723002/diff/20001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/2777723002/diff/20001/AUTHORS#newcode102
AUTHORS:102: Birunthan Mohanathas <birunthan@mohanathas.com>
Did you sign the CLA? I can't seem to find it.

https://cla.developers.google.com/

https://codereview.chromium.org/2777723002/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_test_template.h (right):

https://codereview.chromium.org/2777723002/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_test_template.h:441:
clipboard_writer.WriteData(payload.data(), static_cast<int>(payload.size()),
I think it'd be easier to read if we just renamed these tests to denote that
they're exercising WritePickledData, and add a new test for WriteData().

https://codereview.chromium.org/2777723002/diff/20001/ui/base/clipboard/scope...
File ui/base/clipboard/scoped_clipboard_writer.h (right):

https://codereview.chromium.org/2777723002/diff/20001/ui/base/clipboard/scope...
ui/base/clipboard/scoped_clipboard_writer.h:64: // Adds arbitrary data to
clipboard.
Nit: Adds -> Write

https://codereview.chromium.org/2777723002/diff/20001/ui/base/clipboard/scope...
ui/base/clipboard/scoped_clipboard_writer.h:66: int size,
Please use size_t for the external interface.