Issue 2777683002: Move JPEGImageDecoder to SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2777683002: Move JPEGImageDecoder to SkCodec

Created:
3 years, 9 months ago by cblume

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, kinuko+watch

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move JPEGImageDecoder to SkCodec SkCodec is gaining advantages over Blink's image decoders. scroggo@ has a nice summary: - Skia already has some features that Chromium is interested in: - decoding scaled versions of images - decoding subsets (i.e. issue 468914) - SIMD optimizations for writing pixels - In general, sharing code means that new features/bug fixes in Android benefit Chromium and vice versa - Skia's API is designed to allow the client to handle caching, so that the client that knows the bigger picture can make caching decisions in a more informed way than ImageDecoder can. BUG=715817

Patch Set 1 #

Patch Set 2 : Use shared SegmentStream #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -813 lines)			Patch
M	skia/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h	View	1	3 chunks	+13 lines, -12 lines	0 comments	Download
M	third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp	View		5 chunks	+120 lines, -801 lines	0 comments	Download

Depends on Patchset:

Issue 2565323003 Patch 1180001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

cblume

3 years, 7 months ago (2017-04-26 23:21:24 UTC) #1

Description was changed from

==========
Move jpeg image decoder to SkCodec

SkCodec is gaining advantages over Blink's image decoders.
scroggo@ has a nice summary:

- Skia already has some features that Chromium is interested in:
  - decoding scaled versions of images
  - decoding subsets (i.e. issue 468914)
  - SIMD optimizations for writing pixels
- In general, sharing code means that new features/bug fixes in Android
  benefit Chromium and vice versa
- Skia's API is designed to allow the client to handle caching, so that
  the client that knows the bigger picture can make caching decisions in
  a more informed way than ImageDecoder can.

BUG=663569
==========

to

==========
Move JPEGImageDecoder to SkCodec

SkCodec is gaining advantages over Blink's image decoders.
scroggo@ has a nice summary:

- Skia already has some features that Chromium is interested in:
  - decoding scaled versions of images
  - decoding subsets (i.e. issue 468914)
  - SIMD optimizations for writing pixels
- In general, sharing code means that new features/bug fixes in Android
  benefit Chromium and vice versa
- Skia's API is designed to allow the client to handle caching, so that
  the client that knows the bigger picture can make caching decisions in
  a more informed way than ImageDecoder can.

BUG=715817
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages