Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_unittest.cc

Issue 2777633003: Avoid duplicate math when computing VR scene hierarchy. (Closed)
Patch Set: s/GetTransform()/mutable_transform()/ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/vr_shell/ui_scene.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/ui_scene_unittest.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_unittest.cc b/chrome/browser/android/vr_shell/ui_scene_unittest.cc
index c58f94b616f70d341b4521fad66d0012d36fa396..a538189806f07ea3550242f6b385602ca9d866a4 100644
--- a/chrome/browser/android/vr_shell/ui_scene_unittest.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_unittest.cc
@@ -126,7 +126,6 @@ TEST(UiScene, ParentTransformAppliesToChild) {
const gvr::Vec3f origin({0, 0, 0});
const gvr::Vec3f point({1, 0, 0});
- // Check resulting transform with no screen tilt.
scene.UpdateTransforms(0);
auto new_origin = MatrixVectorMul(child->TransformMatrix(), origin);
auto new_point = MatrixVectorMul(child->TransformMatrix(), point);
« no previous file with comments | « chrome/browser/android/vr_shell/ui_scene.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698