Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 277763002: Prevent squashing into your own compositing container (Closed)

Created:
6 years, 7 months ago by abarth-chromium
Modified:
6 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Prevent squashing into your own compositing container If you squash on to your compositing container, you'll draw in the wrong order because you'll draw after other RenderLayers that come after you in paint order into your compositing container. R=chrishtr@chromium.org BUG=370862 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173709

Patch Set 1 #

Patch Set 2 : Fix whitespace nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
A LayoutTests/compositing/squashing/attempting-to-squash-into-compositing-container.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/attempting-to-squash-into-compositing-container-expected.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositingLayerAssigner.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
chrishtr
lgtm
6 years, 7 months ago (2014-05-09 00:19:22 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 7 months ago (2014-05-09 00:24:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/277763002/20001
6 years, 7 months ago (2014-05-09 00:25:58 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 01:34:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 02:13:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6736)
6 years, 7 months ago (2014-05-09 02:13:29 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 7 months ago (2014-05-09 02:45:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/277763002/20001
6 years, 7 months ago (2014-05-09 02:46:06 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 03:34:18 UTC) #9
Message was sent while issue was closed.
Change committed as 173709

Powered by Google App Engine
This is Rietveld 408576698