content/renderer/media/media_stream_audio_source.h - Issue 2777583002: Move getUserMedia finish to "when audio track configured".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_source.h

Issue 2777583002: Move getUserMedia finish to "when audio track configured". (Closed)

Patch Set: Fix error introduced when addressing review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_stream_audio_source.h

diff --git a/content/renderer/media/media_stream_audio_source.h b/content/renderer/media/media_stream_audio_source.h

index 392dac046bb492b87ce6b1219249de29f1da9011..42ef81a94fe9ed50cd8a407007201049ef947db5 100644

--- a/content/renderer/media/media_stream_audio_source.h

+++ b/content/renderer/media/media_stream_audio_source.h

@@ -82,7 +82,7 @@ class CONTENT_EXPORT MediaStreamAudioSource

// implementation of the content::MediaStreamAudioTrack interface, which

// becomes associated with and owned by |track|. Returns true if the source

// was successfully started.

- bool ConnectToTrack(const blink::WebMediaStreamTrack& track);

+ virtual bool ConnectToTrack(const blink::WebMediaStreamTrack& track);

// Returns the current format of the audio passing through this source to the

// sinks. This can return invalid parameters if the source has not yet been