Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2777533002: Report compile-time error on invalid constructors. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index 4f8b29fdd76eccac3c769eeeac63073cfac7899c..a14190a032e685fe2dc6eb303795ebc7f4a86ca4 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -567,6 +567,16 @@ class KernelTarget extends TargetImplementation {
superTarget ??= defaultSuperConstructor(cls);
Initializer initializer;
if (superTarget == null) {
+ Uri uri = constructor.enclosingClass.fileUri == null
+ ? null
+ : Uri.parse(constructor.enclosingClass.fileUri);
+ InputError error = new InputError(
+ uri,
+ constructor.fileOffset,
+ "${cls.superclass.name} has no constructor that takes zero"
karlklose 2017/03/24 08:54:08 'zero' -> 'no'?
ahe 2017/03/24 12:47:58 Done.
+ " arguments.");
+ print(error.format());
+ errors.add(error);
initializer = new InvalidInitializer();
} else {
initializer =

Powered by Google App Engine
This is Rietveld 408576698