Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 277753004: Android: optimizes jni_generator. (Closed)

Created:
6 years, 7 months ago by bulach
Modified:
6 years, 7 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: optimizes jni_generator. ContentViewCore.java: Before: real 1m25.705s After: real 0m0.257s There was a few overly cautious "non-greedy" terminations, and a few optional matches outside their respective optional blocks. BUG=371520 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269575

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M base/android/jni_generator/jni_generator.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
ptal
6 years, 7 months ago (2014-05-09 09:38:06 UTC) #1
rmcilroy
On 2014/05/09 09:38:06, bulach wrote: > ptal From my limited knowledge of regexp this looks ...
6 years, 7 months ago (2014-05-09 09:52:32 UTC) #2
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 7 months ago (2014-05-09 13:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/277753004/20001
6 years, 7 months ago (2014-05-09 13:07:43 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 12:15:10 UTC) #5
Message was sent while issue was closed.
Change committed as 269575

Powered by Google App Engine
This is Rietveld 408576698