Oilpan: Prepare to move FormController and DocumentState to Oilpan heap, and remove RefPtrs to HTML…

Oilpan: Prepare to move FormController and DocumentState to Oilpan heap, and remove RefPtrs to HTMLFormControlElement and HTMLFormControlElementWithState.

Note: ValidationMessage has a raw pointer member to HTMLFormControlElement. This
CL doesn't make it traceable because a CL to remove ValidationMessage class is
in-progress. A ValidationMessage object is owned by the HTMLFormControlElement
object and the raw pointer is safe.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173710

[tkent, 2014-05-09 02:17:55]

Please review this.

[keishi, 2014-05-09 02:25:44]

lgtm

[haraken, 2014-05-09 02:31:17]

LGTM

[tkent, 2014-05-09 02:41:05]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-05-09 02:42:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/277753003/1

[commit-bot: I haz the power, 2014-05-09 03:37:49]

Change committed as 173710

[Mads Ager (chromium), 2014-05-09 05:40:07]

LGTM

https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
File Source/core/html/forms/FormController.h (right):

https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
Source/core/html/forms/FormController.h:77: class DocumentState : public
RefCountedWillBeGarbageCollectedFinalized<DocumentState> {
Looks like this one does not need finalization and could be GarbageCollected
(with the declare empty destructor macro)?

[tkent, 2014-05-09 06:07:22]

https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
File Source/core/html/forms/FormController.h (right):

https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
Source/core/html/forms/FormController.h:77: class DocumentState : public
RefCountedWillBeGarbageCollectedFinalized<DocumentState> {
On 2014/05/09 05:40:08, Mads Ager (chromium) wrote:
> Looks like this one does not need finalization and could be GarbageCollected
> (with the declare empty destructor macro)?

I tried it, but blink_gc_plugin warned that HeapHashSet needed finalization.

[zerny-chromium, 2014-05-09 06:41:17]

lgtm2

https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
File Source/core/html/forms/FormController.h (right):

https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
Source/core/html/forms/FormController.h:77: class DocumentState : public
RefCountedWillBeGarbageCollectedFinalized<DocumentState> {
On 2014/05/09 06:07:23, tkent wrote:
> On 2014/05/09 05:40:08, Mads Ager (chromium) wrote:
> > Looks like this one does not need finalization and could be GarbageCollected
> > (with the declare empty destructor macro)?
> 
> I tried it, but blink_gc_plugin warned that HeapHashSet needed finalization.

Yes. The ListHashSet currently has a user declared destructor but is a noop when
using the HeapAllocator. I'll make a followup CL to remove it.

[Mads Ager (chromium), 2014-05-09 06:56:33]

On 2014/05/09 06:41:17, zerny-chromium wrote:
> lgtm2
> 
>
https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
> File Source/core/html/forms/FormController.h (right):
> 
>
https://codereview.chromium.org/277753003/diff/1/Source/core/html/forms/FormC...
> Source/core/html/forms/FormController.h:77: class DocumentState : public
> RefCountedWillBeGarbageCollectedFinalized<DocumentState> {
> On 2014/05/09 06:07:23, tkent wrote:
> > On 2014/05/09 05:40:08, Mads Ager (chromium) wrote:
> > > Looks like this one does not need finalization and could be
GarbageCollected
> > > (with the declare empty destructor macro)?
> > 
> > I tried it, but blink_gc_plugin warned that HeapHashSet needed finalization.
> 
> Yes. The ListHashSet currently has a user declared destructor but is a noop
when
> using the HeapAllocator. I'll make a followup CL to remove it.

Thank you! :)