Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2777493003: Include control clip in list of clip-related properties. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2270 matching lines...) Expand 10 before | Expand all | Expand 10 after
2281 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const { 2281 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
2282 if (hasNonCompositedScrollbars() || getSelectionState() != SelectionNone || 2282 if (hasNonCompositedScrollbars() || getSelectionState() != SelectionNone ||
2283 hasBoxDecorationBackground() || styleRef().hasBoxDecorations() || 2283 hasBoxDecorationBackground() || styleRef().hasBoxDecorations() ||
2284 styleRef().hasVisualOverflowingEffect()) 2284 styleRef().hasVisualOverflowingEffect())
2285 return false; 2285 return false;
2286 2286
2287 // If the box has clip or mask, we need issue paint invalidation to cover 2287 // If the box has clip or mask, we need issue paint invalidation to cover
2288 // the changed part of children when the box got resized. In SPv2 this is 2288 // the changed part of children when the box got resized. In SPv2 this is
2289 // handled by detecting paint property changes. 2289 // handled by detecting paint property changes.
2290 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2290 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2291 if (hasClipRelatedProperty() || hasControlClip() || hasMask()) 2291 if (hasClipRelatedProperty() || hasMask())
2292 return false; 2292 return false;
2293 } 2293 }
2294 2294
2295 // If the box paints into its own backing, we can assume that it's painting 2295 // If the box paints into its own backing, we can assume that it's painting
2296 // may have some effect. For example, honoring the border-radius clip on 2296 // may have some effect. For example, honoring the border-radius clip on
2297 // a composited child paints into a mask for an otherwise non-painting 2297 // a composited child paints into a mask for an otherwise non-painting
2298 // element, because children of that element will require the mask. 2298 // element, because children of that element will require the mask.
2299 if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking) 2299 if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking)
2300 return false; 2300 return false;
2301 2301
(...skipping 3443 matching lines...) Expand 10 before | Expand all | Expand 10 after
5745 5745
5746 void LayoutBox::MutableForPainting:: 5746 void LayoutBox::MutableForPainting::
5747 savePreviousContentBoxSizeAndLayoutOverflowRect() { 5747 savePreviousContentBoxSizeAndLayoutOverflowRect() {
5748 auto& rareData = layoutBox().ensureRareData(); 5748 auto& rareData = layoutBox().ensureRareData();
5749 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true; 5749 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true;
5750 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size(); 5750 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size();
5751 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect(); 5751 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect();
5752 } 5752 }
5753 5753
5754 } // namespace blink 5754 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698