Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/context_menu/context_menu_egtest.mm

Issue 2777463002: Make custom GREYAction methods Chromium C-Style. (Closed)
Patch Set: cleanup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/autofill/form_input_egtest.mm ('k') | ios/chrome/browser/ui/settings/block_popups_egtest.mm » ('j') | ios/web/public/test/earl_grey/web_view_actions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/context_menu/context_menu_egtest.mm
diff --git a/ios/chrome/browser/context_menu/context_menu_egtest.mm b/ios/chrome/browser/context_menu/context_menu_egtest.mm
index 3d29a73b139420c3aef21b5c11cc0401bbf2711c..f333aab9807969a3cebb5372d2494877da4b7a66 100644
--- a/ios/chrome/browser/context_menu/context_menu_egtest.mm
+++ b/ios/chrome/browser/context_menu/context_menu_egtest.mm
@@ -79,8 +79,8 @@ void LongPressElementAndTapOnButton(const char* elementId,
id<GREYMatcher> webViewMatcher =
web::WebViewInWebState(chrome_test_util::GetCurrentWebState());
[[EarlGrey selectElementWithMatcher:webViewMatcher]
- performAction:chrome_test_util::longPressElementForContextMenu(elementId,
- true)];
+ performAction:chrome_test_util::LongPressElementForContextMenu(
+ elementId, true /* menu should appear */)];
Eugene But (OOO till 7-30) 2017/03/24 16:24:31 Do you want to fix valriable name? s/elementId/ele
baxley 2017/03/24 16:48:07 Done.
[[EarlGrey selectElementWithMatcher:contextMenuItemButton]
assertWithMatcher:grey_notNil()];
« no previous file with comments | « ios/chrome/browser/autofill/form_input_egtest.mm ('k') | ios/chrome/browser/ui/settings/block_popups_egtest.mm » ('j') | ios/web/public/test/earl_grey/web_view_actions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698