Issue 277743002: Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded, and fix a bug…

Issue 277743002: Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded, and fix a bug… (Closed)

Created:
6 years, 7 months ago by juyik

Modified:
6 years, 7 months ago

Reviewers:
Nicolas Zea, jianli

CC:
chromium-reviews, fgorski

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded, and fix a bug that previously causes this cl to crash the browser upon signin. Basically GCMStatsRecorder::RecordRegistrationResponse() method did not check whether is_recording_ is true or not, so it always records. When the user signs in, a registration event is automatically triggered, but since the gcm-internals page has not been loaded yet, a callback object is still NULL. Therefore recorder calling this callback will crash the browser. I have added the check as well as test case for this scenario. BUG=341256, 371259 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269622

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing Jian's comment. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -8 lines)			Patch
M	chrome/browser/services/gcm/gcm_service.cc	View	1	3 chunks	+14 lines, -1 line	0 comments	Download
M	google_apis/gcm/gcm_client.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	google_apis/gcm/gcm_client_impl.h	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	google_apis/gcm/gcm_client_impl.cc	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	google_apis/gcm/gcm_client_impl_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	google_apis/gcm/monitoring/gcm_stats_recorder.h	View		4 chunks	+21 lines, -0 lines	0 comments	Download
M	google_apis/gcm/monitoring/gcm_stats_recorder.cc	View		9 chunks	+17 lines, -1 line	0 comments	Download
M	google_apis/gcm/monitoring/gcm_stats_recorder_unittest.cc	View		2 chunks	+46 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jianli

lgtm https://codereview.chromium.org/277743002/diff/1/chrome/browser/services/gcm/gcm_service.cc File chrome/browser/services/gcm/gcm_service.cc (right): https://codereview.chromium.org/277743002/diff/1/chrome/browser/services/gcm/gcm_service.cc#newcode855 chrome/browser/services/gcm/gcm_service.cc:855: if (!request_gcm_statistics_callback_.is_null()) Please comment on why the callback ...

6 years, 7 months ago (2014-05-09 17:26:26 UTC) #2

juyik

https://codereview.chromium.org/277743002/diff/1/chrome/browser/services/gcm/gcm_service.cc File chrome/browser/services/gcm/gcm_service.cc (right): https://codereview.chromium.org/277743002/diff/1/chrome/browser/services/gcm/gcm_service.cc#newcode855 chrome/browser/services/gcm/gcm_service.cc:855: if (!request_gcm_statistics_callback_.is_null()) On 2014/05/09 17:26:27, jianli wrote: > Please ...

6 years, 7 months ago (2014-05-09 18:40:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juyik@chromium.org/277743002/20001

6 years, 7 months ago (2014-05-09 18:44:25 UTC) #6

Message was sent while issue was closed.

Change committed as 269622

Expand Messages | Collapse Messages