Issue 2777413002: Revert "VM: [Kernel] Avoid emitting :expr_temp and capturing :iterator"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2777413002: Revert "VM: [Kernel] Avoid emitting :expr_temp and capturing :iterator" (Closed)

Created:
3 years, 9 months ago by jensj

Modified:
3 years, 9 months ago

Reviewers:
Dmitry Olshansky, Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "VM: [Kernel] Avoid emitting :expr_temp and capturing :iterator" This commit caused vm-kernel-linux-debug-x64-be to become red because service/next_through_simple_async_test failed. This reverts commit 3d78c064124b9b47a0eed172658da62b62df2229. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/b5a7a943055abd1acb15f61dcdf76cdeef099469

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -39 lines)			Patch
	M	runtime/vm/kernel_to_il.cc	View		4 chunks	+1 line, -38 lines	0 comments	Download
	M	tests/language/language_kernel.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

jensj

3 years, 9 months ago (2017-03-28 07:29:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b5a7a943055abd1acb15f61dcdf76cdeef099469 (presubmit successful).