Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2777393003: Remove use JavaScriptBackend and Compiler from SsaCodeGenerator (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove use JavaScriptBackend and Compiler from SsaCodeGenerator This is another move towards passing all information through data objects computed by previous phases rather than pulling it directly from Backend or Compiler. This is needed to support a shift from model K to model J between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/ad81a25ed1a3f72fd3286e15326b278b39aaf16d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -268 lines) Patch
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 7 chunks +10 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 75 chunks +275 lines, -246 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-28 13:25:26 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-28 18:27:45 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-03-29 10:00:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad81a25ed1a3f72fd3286e15326b278b39aaf16d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698