Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: net/cert/x509_certificate.h

Issue 2777383002: Update SSL error handling code to account for Subject CN deprecation (Closed)
Patch Set: Address Mark Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/data/ssl/certificates/subjectAltName_www_example_com.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate.h
diff --git a/net/cert/x509_certificate.h b/net/cert/x509_certificate.h
index 7840292a9ecd158234a842b861649349ae0d569e..8d52365b087f5cb165f4005c5c673fc5a048036e 100644
--- a/net/cert/x509_certificate.h
+++ b/net/cert/x509_certificate.h
@@ -192,10 +192,13 @@ class NET_EXPORT X509Certificate
const base::Time& valid_start() const { return valid_start_; }
const base::Time& valid_expiry() const { return valid_expiry_; }
- // Gets the DNS names in the certificate. Pursuant to RFC 2818, Section 3.1
+ // Gets the DNS names in the certificate. Pursuant to RFC 2818, Section 3.1
// Server Identity, if the certificate has a subjectAltName extension of
// type dNSName, this method gets the DNS names in that extension.
// Otherwise, it gets the common name in the subject field.
+ //
+ // Note: Chrome has deprecated fallback to the subject field, see
+ // https://crbug.com/308330; prefer GetSubjectAltName() instead.
void GetDNSNames(std::vector<std::string>* dns_names) const;
// Gets the subjectAltName extension field from the certificate, if any.
« no previous file with comments | « net/BUILD.gn ('k') | net/data/ssl/certificates/subjectAltName_www_example_com.pem » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698