Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2638)

Unified Diff: chrome/browser/ssl/ssl_error_handler.h

Issue 2777383002: Update SSL error handling code to account for Subject CN deprecation (Closed)
Patch Set: Address Mark Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_handler.h
diff --git a/chrome/browser/ssl/ssl_error_handler.h b/chrome/browser/ssl/ssl_error_handler.h
index f0dc06b43adeac1ba7f45758bdf57d8c99c4b9b3..319eb612184784a1e91c865a775d112b432bb441 100644
--- a/chrome/browser/ssl/ssl_error_handler.h
+++ b/chrome/browser/ssl/ssl_error_handler.h
@@ -66,15 +66,16 @@ class SSLErrorHandler : public content::WebContentsUserData<SSLErrorHandler>,
// Public for testing.
enum UMAEvent {
HANDLE_ALL = 0,
- SHOW_CAPTIVE_PORTAL_INTERSTITIAL_NONOVERRIDABLE,
- SHOW_CAPTIVE_PORTAL_INTERSTITIAL_OVERRIDABLE,
- SHOW_SSL_INTERSTITIAL_NONOVERRIDABLE,
- SHOW_SSL_INTERSTITIAL_OVERRIDABLE,
- WWW_MISMATCH_FOUND,
- WWW_MISMATCH_URL_AVAILABLE,
- WWW_MISMATCH_URL_NOT_AVAILABLE,
- SHOW_BAD_CLOCK,
- CAPTIVE_PORTAL_CERT_FOUND,
+ SHOW_CAPTIVE_PORTAL_INTERSTITIAL_NONOVERRIDABLE = 1,
+ SHOW_CAPTIVE_PORTAL_INTERSTITIAL_OVERRIDABLE = 2,
+ SHOW_SSL_INTERSTITIAL_NONOVERRIDABLE = 3,
+ SHOW_SSL_INTERSTITIAL_OVERRIDABLE = 4,
+ WWW_MISMATCH_FOUND = 5, // Deprecated in M59 by WWW_MISMATCH_FOUND_IN_SAN.
+ WWW_MISMATCH_URL_AVAILABLE = 6,
+ WWW_MISMATCH_URL_NOT_AVAILABLE = 7,
+ SHOW_BAD_CLOCK = 8,
+ CAPTIVE_PORTAL_CERT_FOUND = 9,
+ WWW_MISMATCH_FOUND_IN_SAN = 10,
SSL_ERROR_HANDLER_EVENT_COUNT
};
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698