chrome/browser/ssl/ssl_error_handler.h - Issue 2777383002: Update SSL error handling code to account for Subject CN deprecation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_handler.h

Issue 2777383002: Update SSL error handling code to account for Subject CN deprecation (Closed)

Patch Set: Update histogram text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_error_handler.h

diff --git a/chrome/browser/ssl/ssl_error_handler.h b/chrome/browser/ssl/ssl_error_handler.h

index f0dc06b43adeac1ba7f45758bdf57d8c99c4b9b3..2e89db0f0bb7f54ed46157e6fb37be38ac54a909 100644

--- a/chrome/browser/ssl/ssl_error_handler.h

+++ b/chrome/browser/ssl/ssl_error_handler.h

@@ -70,11 +70,12 @@ class SSLErrorHandler : public content::WebContentsUserData<SSLErrorHandler>,

SHOW_CAPTIVE_PORTAL_INTERSTITIAL_OVERRIDABLE,

SHOW_SSL_INTERSTITIAL_NONOVERRIDABLE,

SHOW_SSL_INTERSTITIAL_OVERRIDABLE,

- WWW_MISMATCH_FOUND,

+ WWW_MISMATCH_FOUND, // Deprecated by WWW_MISMATCH_FOUND_IN_SAN

WWW_MISMATCH_URL_AVAILABLE,

WWW_MISMATCH_URL_NOT_AVAILABLE,

SHOW_BAD_CLOCK,

CAPTIVE_PORTAL_CERT_FOUND,

+ WWW_MISMATCH_FOUND_IN_SAN,

SSL_ERROR_HANDLER_EVENT_COUNT

};