Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2777343002: exo: Rotate cursor snapshot for rotated displays (Closed)

Created:
3 years, 9 months ago by Dominik Laskowski
Modified:
3 years, 7 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Rotate cursor snapshot for rotated displays BUG=631136 BUG=642894 TEST=caroline: Cursor on rotated displays has correct orientation.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nit #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Rebase #

Patch Set 5 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -15 lines) Patch
M components/exo/pointer.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M components/exo/pointer.cc View 1 2 3 4 3 chunks +25 lines, -2 lines 0 comments Download
M ui/display/display.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/display/display.cc View 1 2 2 chunks +17 lines, -12 lines 0 comments Download

Depends on Patchset:

Issue 2812663002 Patch 80001

Dependent Patchsets:

Issue 2779823002 Patch 80001
Issue 2779823002 Patch 100001

Messages

Total messages: 9 (2 generated)
Dominik Laskowski
PTAL. Split from https://codereview.chromium.org/2780623002/
3 years, 9 months ago (2017-03-27 21:52:11 UTC) #2
oshima
lgtm with a nit https://codereview.chromium.org/2777343002/diff/1/ui/display/display.h File ui/display/display.h (right): https://codereview.chromium.org/2777343002/diff/1/ui/display/display.h#newcode104 ui/display/display.h:104: static int RotationAsDegree(Rotation rotation); Can ...
3 years, 8 months ago (2017-03-28 12:50:16 UTC) #3
Dominik Laskowski
https://codereview.chromium.org/2777343002/diff/1/ui/display/display.h File ui/display/display.h (right): https://codereview.chromium.org/2777343002/diff/1/ui/display/display.h#newcode104 ui/display/display.h:104: static int RotationAsDegree(Rotation rotation); On 2017/03/28 12:50:15, oshima wrote: ...
3 years, 8 months ago (2017-03-30 01:17:15 UTC) #4
Dominik Laskowski
Ping?
3 years, 7 months ago (2017-04-28 21:12:29 UTC) #5
reveman
lgtm with nit https://codereview.chromium.org/2777343002/diff/40001/components/exo/pointer.h File components/exo/pointer.h (right): https://codereview.chromium.org/2777343002/diff/40001/components/exo/pointer.h#newcode104 components/exo/pointer.h:104: display::Display::Rotation rotation_ = display::Display::ROTATE_0; nit: please ...
3 years, 7 months ago (2017-04-28 21:27:42 UTC) #6
Dominik Laskowski
https://codereview.chromium.org/2777343002/diff/40001/components/exo/pointer.h File components/exo/pointer.h (right): https://codereview.chromium.org/2777343002/diff/40001/components/exo/pointer.h#newcode104 components/exo/pointer.h:104: display::Display::Rotation rotation_ = display::Display::ROTATE_0; On 2017/04/28 21:27:42, reveman wrote: ...
3 years, 7 months ago (2017-05-06 00:37:16 UTC) #7
Dominik Laskowski
3 years, 7 months ago (2017-05-22 21:41:54 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698