Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5399)

Unified Diff: chrome/test/chromedriver/run_buildbot_steps.py

Issue 2777233002: [chromedriver] Fix path for server logs and add logging. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/run_buildbot_steps.py
diff --git a/chrome/test/chromedriver/run_buildbot_steps.py b/chrome/test/chromedriver/run_buildbot_steps.py
index f9a3b47828fadd19567166f631961a6403fe6007..5efcfe3f013f5ec66de1805f6d71a0e915fac1ed 100755
--- a/chrome/test/chromedriver/run_buildbot_steps.py
+++ b/chrome/test/chromedriver/run_buildbot_steps.py
@@ -61,9 +61,9 @@ def _ArchivePrebuilts(commit_position):
def _ArchiveServerLogs():
"""Uploads chromedriver server logs to google storage."""
util.MarkBuildStepStart('archive chromedriver server logs')
- for server_log in glob.glob(os.path.join(tempfile.gettempdir(),
- 'chromedriver_*',
- 'chromedriver_log_*')):
+ pathname_pattern = os.path.join(tempfile.gettempdir(), 'chromedriver_log_*')
+ print 'archiving logs from: %s' % pathname_pattern
+ for server_log in glob.glob(pathname_pattern):
if os.path.isfile(server_log):
base_name = os.path.basename(server_log)
util.AddLink(base_name, '%s/%s' % (SERVER_LOGS_LINK, base_name))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698