[builtins] Introduce new TFC macro and auto-generate TFS descriptors

src/builtins/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/api.h"
 #include "src/assembler-inl.h"
 #include "src/builtins/builtins-descriptors.h"
 #include "src/callable.h"
 #include "src/code-events.h"
@@ skipping 124 matching lines @@
                       kBuiltinFlags, #Name);                                \
   builtins_[index++] = code;
 #define BUILD_API(Name)                                             \
   code = BuildAdaptor(isolate, FUNCTION_ADDR(Builtin_##Name), EXIT, \
                       kBuiltinFlags, #Name);                        \
   builtins_[index++] = code;
 #define BUILD_TFJ(Name, Argc, ...)                                     \
   code = BuildWithCodeStubAssemblerJS(isolate, &Generate_##Name, Argc, \
                                       kBuiltinFlags, #Name);           \
   builtins_[index++] = code;
-#define BUILD_TFS(Name, InterfaceDescriptor, result_size)                   \
+#define BUILD_TFC(Name, InterfaceDescriptor, result_size)                   \
   { InterfaceDescriptor##Descriptor descriptor(isolate); }                  \
   code = BuildWithCodeStubAssemblerCS(isolate, &Generate_##Name,            \
                                       CallDescriptors::InterfaceDescriptor, \
                                       kBuiltinFlags, #Name, result_size);   \
   builtins_[index++] = code;
+#define BUILD_TFS(Name, ...)                                                \
+  /* Return size for generic TF builtins (stub linkage) is always 1. */     \
+  code = BuildWithCodeStubAssemblerCS(isolate, &Generate_##Name,            \
+                                      CallDescriptors::Name, kBuiltinFlags, \
+                                      #Name, 1);                            \
+  builtins_[index++] = code;
 #define BUILD_TFH(Name, Kind, Extra, InterfaceDescriptor)              \
   { InterfaceDescriptor##Descriptor descriptor(isolate); }             \
   /* Return size for IC builtins/handlers is always 1. */              \
   code = BuildWithCodeStubAssemblerCS(                                 \
       isolate, &Generate_##Name, CallDescriptors::InterfaceDescriptor, \
       Code::ComputeFlags(Code::Kind, Extra), #Name, 1);                \
   builtins_[index++] = code;
 #define BUILD_ASM(Name)                                                        \
   code =                                                                       \
       BuildWithMacroAssembler(isolate, Generate_##Name, kBuiltinFlags, #Name); \
   builtins_[index++] = code;
 
-    BUILTIN_LIST(BUILD_CPP, BUILD_API, BUILD_TFJ, BUILD_TFS, BUILD_TFH,
-                 BUILD_ASM, BUILD_ASM);
+    BUILTIN_LIST(BUILD_CPP, BUILD_API, BUILD_TFJ, BUILD_TFC, BUILD_TFS,
+                 BUILD_TFH, BUILD_ASM, BUILD_ASM);
 
 #undef BUILD_CPP
 #undef BUILD_API
 #undef BUILD_TFJ
+#undef BUILD_TFC
 #undef BUILD_TFS
 #undef BUILD_TFH
 #undef BUILD_ASM
     CHECK_EQ(builtin_count, index);
     for (int i = 0; i < builtin_count; i++) {
       Code::cast(builtins_[i])->set_builtin_index(i);
     }
 
 #define SET_PROMISE_REJECTION_PREDICTION(Name) \
   Code::cast(builtins_[k##Name])->set_is_promise_rejection(true);
@@ skipping 108 matching lines @@
 // static
 Callable Builtins::CallableFor(Isolate* isolate, Name name) {
   switch (name) {
 #define CASE(Name, ...)                                                  \
   case k##Name: {                                                        \
     Handle<Code> code(Code::cast(isolate->builtins()->builtins_[name])); \
     auto descriptor = Builtin_##Name##_InterfaceDescriptor(isolate);     \
     return Callable(code, descriptor);                                   \
   }
     BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, CASE, CASE,
-                 IGNORE_BUILTIN, IGNORE_BUILTIN)
+                 CASE, IGNORE_BUILTIN, IGNORE_BUILTIN)
 #undef CASE
     default:
       UNREACHABLE();
       return Callable(Handle<Code>::null(), VoidDescriptor(isolate));
   }
 }
 
 // static
 const char* Builtins::name(int index) {
   switch (index) {
@@ skipping 26 matching lines @@
 
 // static
 bool Builtins::IsCpp(int index) {
   DCHECK(0 <= index && index < builtin_count);
   switch (index) {
 #define CASE(Name, ...) \
   case k##Name:         \
     return true;
 #define BUILTIN_LIST_CPP(V)                                       \
   BUILTIN_LIST(V, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
-               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
+               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
     BUILTIN_LIST_CPP(CASE)
 #undef BUILTIN_LIST_CPP
 #undef CASE
     default:
       return false;
   }
   UNREACHABLE();
 }
 
 // static
 bool Builtins::IsApi(int index) {
   DCHECK(0 <= index && index < builtin_count);
   switch (index) {
 #define CASE(Name, ...) \
   case k##Name:         \
     return true;
 #define BUILTIN_LIST_API(V)                                       \
   BUILTIN_LIST(IGNORE_BUILTIN, V, IGNORE_BUILTIN, IGNORE_BUILTIN, \
-               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
+               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
     BUILTIN_LIST_API(CASE);
 #undef BUILTIN_LIST_API
 #undef CASE
     default:
       return false;
   }
   UNREACHABLE();
 }
 
 // static
@@ skipping 30 matching lines @@
   // TODO(jochen): Remove this.
   if (responsible_context.is_null()) {
     return true;
   }
   if (*responsible_context == target->context()) return true;
   return isolate->MayAccess(responsible_context, target_global_proxy);
 }
 
 }  // namespace internal
 }  // namespace v8