Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: base/trace_event/trace_config_category_filter.h

Issue 2777203004: Avoid calling strlen() where possible in base/trace_config (Closed)
Patch Set: Keep DCHECKs. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_config.cc ('k') | base/trace_event/trace_config_category_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_config_category_filter.h
diff --git a/base/trace_event/trace_config_category_filter.h b/base/trace_event/trace_config_category_filter.h
index df8c3a5b2a70d3e7a5d4762fa79fa20035905f18..0d7dba0374ebe3767e098bc18ab3a938d336a287 100644
--- a/base/trace_event/trace_config_category_filter.h
+++ b/base/trace_event/trace_config_category_filter.h
@@ -40,13 +40,13 @@ class BASE_EXPORT TraceConfigCategoryFilter {
// Returns true if at least one category in the list is enabled by this
// trace config. This is used to determine if the category filters are
// enabled in the TRACE_* macros.
- bool IsCategoryGroupEnabled(const char* category_group_name) const;
+ bool IsCategoryGroupEnabled(const StringPiece& category_group_name) const;
// Returns true if the category is enabled according to this trace config.
// This tells whether a category is enabled from the TraceConfig's
// perspective. Please refer to IsCategoryGroupEnabled() to determine if a
// category is enabled from the tracing runtime's perspective.
- bool IsCategoryEnabled(const char* category_name) const;
+ bool IsCategoryEnabled(const StringPiece& category_name) const;
void ToDict(DictionaryValue* dict) const;
« no previous file with comments | « base/trace_event/trace_config.cc ('k') | base/trace_event/trace_config_category_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698