Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2777183004: Make pair iterators inherit from %IteratorPrototype%. (Closed)
Patch Set: Rebased patch with tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index 623d03d975e052032f7af645161e9b1a2b64eb7f..a1637551c8c91802e01ef46f21cedcd33b9783b2 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -507,7 +507,7 @@ def methods_context(interface):
argument.extended_attributes.update(extended_attributes)
return argument
- # [Iterable], iterable<>, maplike<> and setlike<>
+ # iterable<>, maplike<> and setlike<>
iterator_method = None
# FIXME: support Iterable in partial interfaces. However, we don't
@@ -516,8 +516,7 @@ def methods_context(interface):
# http://heycam.github.io/webidl/#idl-overloading
if (not interface.is_partial and (
interface.iterable or interface.maplike or interface.setlike or
- interface.has_indexed_elements or
- 'Iterable' in interface.extended_attributes)):
+ interface.has_indexed_elements)):
used_extended_attributes = {}

Powered by Google App Engine
This is Rietveld 408576698