third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html - Issue 2777183002: Hook up the other Background Fetch Mojo methods with the system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html

Issue 2777183002: Hook up the other Background Fetch Mojo methods with the system (Closed)

Patch Set: Hook up the other Background Fetch Mojo methods with the system Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-getTags.https.html ('k') | third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html b/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html

index 239d40803bf8811fd5661faa0f91b2f3491de260..ecfcee3cf667903fbef9f689ff3f1fd4f9abf664 100644

--- a/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html

+++ b/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html

@@ -45,9 +45,7 @@ promise_test(function(test) {

})

.then(success => {

// The registration had already been aborted, so aborting it again should fail.

- // TODO(peter): This is a change-detector test, and will deliberately

- // start failing when the browser side has been hooked up.

- assert_true(success);

+ assert_false(success);

});

}, 'BackgroundFetchRegistration.abort() return a Promise indicating success.');