Issue 277713003: QuadTree: don't leak deferred inserts past clear()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 277713003: QuadTree: don't leak deferred inserts past clear() (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
djsollen, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

QuadTree: don't leak deferred inserts past clear() BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14670

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/core/SkQuadTree.cpp	View		2 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm https://codereview.chromium.org/277713003/diff/1/src/core/SkQuadTree.cpp File src/core/SkQuadTree.cpp (right): https://codereview.chromium.org/277713003/diff/1/src/core/SkQuadTree.cpp#newcode186 src/core/SkQuadTree.cpp:186: SkASSERT(fEntryPool.allocated() == fEntryPool.available()); should we add this here ...

6 years, 7 months ago (2014-05-09 14:23:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/277713003/1

6 years, 7 months ago (2014-05-09 14:26:14 UTC) #4

Message was sent while issue was closed.

Change committed as 14670

Expand Messages | Collapse Messages