ui/compositor: move the browser compositor thread to the ContextFactory

ui/compositor/test/in_process_context_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/test/in_process_context_factory.h"
 
+#include "base/threading/thread.h"
 #include "cc/output/output_surface.h"
 #include "cc/test/test_shared_bitmap_manager.h"
 #include "ui/compositor/reflector.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_surface.h"
 #include "webkit/common/gpu/context_provider_in_process.h"
 #include "webkit/common/gpu/grcontext_for_webgraphicscontext3d.h"
 #include "webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h"
 
 namespace ui {
 
 InProcessContextFactory::InProcessContextFactory()
     : shared_bitmap_manager_(new cc::TestSharedBitmapManager()) {
   DCHECK_NE(gfx::GetGLImplementation(), gfx::kGLImplementationNone);
+#if defined(OS_CHROMEOS)
+  bool use_thread = !CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kUIDisableThreadedCompositing);
+#else
+  bool use_thread = false;
+#endif
+  if (use_thread) {
+    compositor_thread_.reset(new base::Thread("Browser Compositor"));
+    compositor_thread_->Start();
+  }
 }
 
-InProcessContextFactory::~InProcessContextFactory() {}
+InProcessContextFactory::~InProcessContextFactory() {
+  if (compositor_thread_.get()) {

[danakj, 2014/05/08 22:37:30]

nit: no need .get() for scoped_ptr

[piman, 2014/05/08 22:48:34]

Done.

+    compositor_thread_->Stop();

[danakj, 2014/05/08 22:37:30]

Doesn't this happen in the destructor? Why do we need to do this at all? Does it
help with stacktraces?

[piman, 2014/05/08 22:48:34]

Done.

+    compositor_thread_.reset();
+  }
+}
 
 scoped_ptr<cc::OutputSurface> InProcessContextFactory::CreateOutputSurface(
     Compositor* compositor,
     bool software_fallback) {
   DCHECK(!software_fallback);
   blink::WebGraphicsContext3D::Attributes attrs;
   attrs.depth = false;
   attrs.stencil = false;
   attrs.antialias = false;
   attrs.shareResources = true;
@@ skipping 39 matching lines @@
 }
 
 void InProcessContextFactory::RemoveCompositor(Compositor* compositor) {}
 
 bool InProcessContextFactory::DoesCreateTestContexts() { return false; }
 
 cc::SharedBitmapManager* InProcessContextFactory::GetSharedBitmapManager() {
   return shared_bitmap_manager_.get();
 }
 
+base::MessageLoopProxy* InProcessContextFactory::GetCompositorMessageLoop() {
+  if (!compositor_thread_)
+    return NULL;
+  return compositor_thread_->message_loop_proxy();
+}
+
 }  // namespace ui