Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2777093010: Use entities in NoSuchMethodRegistry (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use entities in NoSuchMethodRegistry This prepares for a kernel based implementation of NoSuchMethodResolver. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/23999a0f1e7c60af57b7fb3874dae54c8e6a8d99

Patch Set 1 #

Patch Set 2 : Move as cast. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -51 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 3 chunks +12 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 8 chunks +23 lines, -16 lines 0 comments Download
A pkg/compiler/lib/src/kernel/no_such_method_resolver.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 1 chunk +14 lines, -1 line 0 comments Download
M tests/compiler/dart2js/assert_message_throw_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-29 13:07:31 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-29 18:14:42 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-03 08:27:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23999a0f1e7c60af57b7fb3874dae54c8e6a8d99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698