Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
diff --git a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
index c1ad69010d894d9fcdeb59725933ae9a5a0ec76c..7bb49b68f428f66c9e136463fe19909854c6bcbb 100644
--- a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
+++ b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
@@ -104,4 +104,38 @@ bool StructTraits<memory_instrumentation::mojom::RequestArgsDataView,
return true;
}
+// static
+bool StructTraits<memory_instrumentation::mojom::ChromeMemDumpDataView,
+ base::trace_event::MemoryDumpCallbackResult::ChromeMemDump>::
+ Read(memory_instrumentation::mojom::ChromeMemDumpDataView input,
+ base::trace_event::MemoryDumpCallbackResult::ChromeMemDump* out) {
+ out->malloc_total_kb = input.malloc_total_kb();
+ out->partition_alloc_total_kb = input.partition_alloc_total_kb();
+ out->blink_gc_total_kb = input.blink_gc_total_kb();
+ out->v8_total_kb = input.v8_total_kb();
+ return true;
+}
+
+// static
+bool StructTraits<memory_instrumentation::mojom::OSMemDumpDataView,
+ base::trace_event::MemoryDumpCallbackResult::OSMemDump>::
+ Read(memory_instrumentation::mojom::OSMemDumpDataView input,
+ base::trace_event::MemoryDumpCallbackResult::OSMemDump* out) {
+ out->resident_set_kb = input.resident_set_kb();
+ return true;
+}
+
+// static
+bool StructTraits<
+ memory_instrumentation::mojom::MemoryDumpCallbackResultDataView,
+ base::trace_event::MemoryDumpCallbackResult>::
+ Read(memory_instrumentation::mojom::MemoryDumpCallbackResultDataView input,
+ base::trace_event::MemoryDumpCallbackResult* out) {
+ if (!input.ReadChromeDump(&out->chrome_dump))
+ return false;
+ if (!input.ReadOsDump(&out->os_dump))
+ return false;
+ return true;
+}
+
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698