Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2777093006: Implement debugger support for async step-out (Closed)

Created:
3 years, 8 months ago by Cutch
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -6 lines) Patch
A runtime/observatory/tests/service/async_star_step_out_test.dart View 1 1 chunk +90 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/async_step_out_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/service_kernel.status View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 3 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
3 years, 8 months ago (2017-03-28 17:20:12 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2777093006/diff/1/runtime/observatory/tests/service/async_star_step_out_test.dart File runtime/observatory/tests/service/async_star_step_out_test.dart (right): https://codereview.chromium.org/2777093006/diff/1/runtime/observatory/tests/service/async_star_step_out_test.dart#newcode86 runtime/observatory/tests/service/async_star_step_out_test.dart:86: stoppedAtLine(LINE_I), // } tail of helper. The implicit ...
3 years, 8 months ago (2017-03-29 01:07:54 UTC) #4
Cutch
https://codereview.chromium.org/2777093006/diff/1/runtime/observatory/tests/service/async_star_step_out_test.dart File runtime/observatory/tests/service/async_star_step_out_test.dart (right): https://codereview.chromium.org/2777093006/diff/1/runtime/observatory/tests/service/async_star_step_out_test.dart#newcode86 runtime/observatory/tests/service/async_star_step_out_test.dart:86: stoppedAtLine(LINE_I), // } tail of helper. On 2017/03/29 01:07:54, ...
3 years, 8 months ago (2017-03-29 14:39:14 UTC) #5
Cutch
3 years, 8 months ago (2017-03-29 14:44:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2815f3f7753b1c6af957575e87a4540ec6569f62.

Powered by Google App Engine
This is Rietveld 408576698