Connect BackgroundFetch to the OfflineItemCollection

content/browser/background_fetch/background_fetch_registration_id.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_REGISTRATION_ID_H_
 #define CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_REGISTRATION_ID_H_
 
 #include <stdint.h>
 #include <string>
 
@@ skipping 21 matching lines @@
   bool operator==(const BackgroundFetchRegistrationId& other) const;
   bool operator!=(const BackgroundFetchRegistrationId& other) const;
 
   // Enables this type to be used in an std::map and std::set.
   // TODO(peter): Delete this when we switch away from using maps.
   bool operator<(const BackgroundFetchRegistrationId& other) const;
 
   // Returns whether this registration id refers to valid data.
   bool is_null() const;
 
+  // Serialize the registration_id into a string so that it can be sent to
+  // embedders in a neutral format. Syntax is:
+  // service_worker_registration_id:origin:tag

[Peter Beverloo, 2017/03/31 01:32:23]

I personally wouldn't document the syntax of the serialized format in the header
file. Since we provide both Serialize and Deserialize methods, the contract can
be that code dealing with a serialized_registration_id should treat it as an
opaque identifier.

[harkness, 2017/03/31 10:11:44]

OK, I've moved the documentation to the .cc file.

+  std::string Serialize() const;
+
+  // Deserialize the string format of a registration_id.
+  static bool Deserialize(const std::string& serialized_registration_id,
+                          BackgroundFetchRegistrationId& out_registration_id);

[Peter Beverloo, 2017/03/31 01:32:23]

micro nit: style guide says static methods should go on top. My personal
preference still is for the reference to become a pointer, because it's much
clearer at call-site that the BFRegId is being written to.

[harkness, 2017/03/31 10:11:44]

Done.

+
   int64_t service_worker_registration_id() const {
     return service_worker_registration_id_;
   }
   const url::Origin& origin() const { return origin_; }
   const std::string& tag() const { return tag_; }
 
  private:
   int64_t service_worker_registration_id_;
   url::Origin origin_;
   std::string tag_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_REGISTRATION_ID_H_