content/public/browser/background_fetch_client.h - Issue 2777063008: Connect BackgroundFetch to the OfflineItemCollection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/background_fetch_client.h

Issue 2777063008: Connect BackgroundFetch to the OfflineItemCollection

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/background_fetch/background_fetch_registration_id.cc ('K') | « content/public/browser/BUILD.gn ('k') | content/public/browser/background_fetch_delegate.h » ('j') | content/public/browser/background_fetch_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_PUBLIC_BROWSER_BACKGROUND_FETCH_CLIENT_H_

	6 #define CONTENT_PUBLIC_BROWSER_BACKGROUND_FETCH_CLIENT_H_

	7

	8 #include "content/common/content_export.h"

	9

	10 namespace content {

	11

	12 class BackgroundFetchDelegate;

	13

	14 class CONTENT_EXPORT BackgroundFetchClient {
	Peter Beverloo 2017/03/29 14:32:13 ++docs on this interface. Especially things like o ++docs on this interface. Especially things like ownership of the pointers. harkness 2017/03/30 12:42:36 Done. Show quoted text On 2017/03/29 14:32:13, Peter Beverloo wrote: > ++docs on this interface. Especially things like ownership of the pointers. Done.
	15 public:

	16 virtual void SetDelegate(BackgroundFetchDelegate* delegate) = 0;

	17 virtual BackgroundFetchDelegate* GetDelegate() const = 0;
	Peter Beverloo 2017/03/29 14:32:13 Why do we need GetDelegate()? Why do we need GetDelegate()? harkness 2017/03/30 12:42:36 I thought we were going to need one, but we don't. Show quoted text On 2017/03/29 14:32:13, Peter Beverloo wrote: > Why do we need GetDelegate()? I thought we were going to need one, but we don't. Removed.
	18 };
	Peter Beverloo 2017/03/29 14:32:13 Virtual base classes need to have a virtual destru Virtual base classes need to have a virtual destructor. Mind defining one? harkness 2017/03/30 12:42:36 Done. Show quoted text On 2017/03/29 14:32:13, Peter Beverloo wrote: > Virtual base classes need to have a virtual destructor. Mind defining one? Done.
	19

	20 } // namespace content

	21

	22 #endif // CONTENT_PUBLIC_BROWSER_BACKGROUND_FETCH_CLIENT_H_

OLD	NEW