Connect BackgroundFetch to the OfflineItemCollection

content/browser/background_fetch/background_fetch_registration_id.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_REGISTRATION_ID_H_
 #define CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_REGISTRATION_ID_H_
 
 #include <stdint.h>
 #include <string>
 
@@ skipping 21 matching lines @@
   bool operator==(const BackgroundFetchRegistrationId& other) const;
   bool operator!=(const BackgroundFetchRegistrationId& other) const;
 
   // Enables this type to be used in an std::map and std::set.
   // TODO(peter): Delete this when we switch away from using maps.
   bool operator<(const BackgroundFetchRegistrationId& other) const;
 
   // Returns whether this registration id refers to valid data.
   bool is_null() const;
 
+  void FromString(const std::string& str);
+  std::string ToString() const;

[Peter Beverloo, 2017/03/29 14:32:12]

Could we call them Serialize and Deserialize(), where the latter is static?
Especially since FromString() doesn't actually return anything, the caller would
not know if decoding fails w/o checking is_null().

(Since this data will be stored in SharedPreferences there's always a chance of
corruption or deliberate mocking with the values.)

[Peter Beverloo, 2017/03/29 14:32:13]

Also ++docs

[harkness, 2017/03/30 12:42:36]

Done.

[harkness, 2017/03/30 12:42:36]

Done.

+
   int64_t service_worker_registration_id() const {
     return service_worker_registration_id_;
   }
   const url::Origin& origin() const { return origin_; }
   const std::string& tag() const { return tag_; }
 
  private:
   int64_t service_worker_registration_id_;
   url::Origin origin_;
   std::string tag_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_REGISTRATION_ID_H_