Connect BackgroundFetch to the OfflineItemCollection

content/browser/background_fetch/background_fetch_context.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_fetch/background_fetch_context.h"
 
 #include "base/memory/ptr_util.h"
 #include "content/browser/background_fetch/background_fetch_data_manager.h"
 #include "content/browser/background_fetch/background_fetch_job_controller.h"
 #include "content/browser/background_fetch/background_fetch_registration_id.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 #include "content/browser/storage_partition_impl.h"
 #include "content/public/browser/browser_context.h"
 
 namespace content {
 
 BackgroundFetchContext::BackgroundFetchContext(
     BrowserContext* browser_context,
     StoragePartitionImpl* storage_partition,
     const scoped_refptr<ServiceWorkerContextWrapper>& service_worker_context)
     : browser_context_(browser_context),
       storage_partition_(storage_partition),
       service_worker_context_(service_worker_context),
       background_fetch_data_manager_(
           base::MakeUnique<BackgroundFetchDataManager>(browser_context)) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);

[Peter Beverloo, 2017/03/29 14:32:12]

BackgroundFetchClient* client = browser_context_->GetBackgroundFetchClient();
if (client)
  client->SetDelegate(this);

[harkness, 2017/03/30 12:42:35]

Done.

 }
 
 BackgroundFetchContext::~BackgroundFetchContext() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);

[Peter Beverloo, 2017/03/29 14:32:12]

BackgroundFetchClient* client = browser_context_->GetBackgroundFetchClient();
if (client)
  client->SetDelegate(nullptr);

[harkness, 2017/03/30 12:42:35]

Done.

 }
 
 void BackgroundFetchContext::Shutdown() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&BackgroundFetchContext::ShutdownOnIO, this));
 }
 
 void BackgroundFetchContext::ShutdownOnIO() {
@@ skipping 53 matching lines @@
 void BackgroundFetchContext::DidFinishFetch(
     const BackgroundFetchRegistrationId& registration_id) {
   DCHECK_GT(active_fetches_.count(registration_id), 0u);
 
   // TODO(peter): Dispatch the `backgroundfetched` or the `backgroundfetchfail`
   // event to the Service Worker.
 
   active_fetches_.erase(registration_id);
 }
 
+void BackgroundFetchContext::CancelDownload(
+    const std::string& registration_id) {}

[Peter Beverloo, 2017/03/29 14:32:12]

micro nit: lack of symmetry in the argument names in the .h/.cc

[harkness, 2017/03/30 12:42:35]

Done.

+
+void BackgroundFetchContext::PauseDownload(const std::string& registration_id) {
+}
+
+void BackgroundFetchContext::ResumeDownload(
+    const std::string& registration_id) {}

[Peter Beverloo, 2017/03/29 14:32:12]

nit: it'd be best to hook these up with the JobController already. (Or add a
TODO if you're worried about merge failures.) Ideally we'd just have
BackgroundFetchJobController::{Cancel,Pause,Resume}, super short and clear.

I guess we should change or extend GetActiveFetch() to also be able to return
inactive background fetches to accommodate for these methods?

[harkness, 2017/03/30 12:42:35]

My plan was to hook these up in the next CL to minimize merge conflicts since
there are such major changes elsewhere.

+
 }  // namespace content