Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2777063005: MD Settings: Show password tooltip for full URL. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/html/action_link.html"> 3 <link rel="import" href="chrome://resources/html/action_link.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-tooltip/paper-too ltip.html">
8 <link rel="import" href="../controls/settings_toggle_button.html"> 9 <link rel="import" href="../controls/settings_toggle_button.html">
9 <link rel="import" href="../controls/extension_controlled_indicator.html"> 10 <link rel="import" href="../controls/extension_controlled_indicator.html">
10 <link rel="import" href="../controls/settings_toggle_button.html"> 11 <link rel="import" href="../controls/settings_toggle_button.html">
11 <link rel="import" href="../global_scroll_target_behavior.html"> 12 <link rel="import" href="../global_scroll_target_behavior.html">
12 <link rel="import" href="../prefs/prefs.html"> 13 <link rel="import" href="../prefs/prefs.html">
13 <link rel="import" href="../settings_shared_css.html"> 14 <link rel="import" href="../settings_shared_css.html">
14 <link rel="import" href="password_edit_dialog.html"> 15 <link rel="import" href="password_edit_dialog.html">
15 <link rel="import" href="passwords_shared_css.html"> 16 <link rel="import" href="passwords_shared_css.html">
16 17
17 <dom-module id="passwords-section"> 18 <dom-module id="passwords-section">
(...skipping 15 matching lines...) Expand all
33 #originUrl { 34 #originUrl {
34 /* The following non-flex directives allow eliding long originUrls from 35 /* The following non-flex directives allow eliding long originUrls from
35 * the left. Forcing rtl should not cause an issue for right-to-left 36 * the left. Forcing rtl should not cause an issue for right-to-left
36 * languages in this case, since valid URL characters are restricted to 37 * languages in this case, since valid URL characters are restricted to
37 * ASCII. 38 * ASCII.
38 */ 39 */
39 direction: rtl; 40 direction: rtl;
40 display: flex; 41 display: flex;
41 } 42 }
42 43
44 #originUrl paper-tooltip {
45 /* URL in the tooltip should be LTR. */
46 direction: ltr;
47 }
48
43 .username-column { 49 .username-column {
44 -webkit-margin-end: 8px; 50 -webkit-margin-end: 8px;
45 -webkit-margin-start: 8px; 51 -webkit-margin-start: 8px;
46 flex: 2; 52 flex: 2;
47 } 53 }
48 54
49 .password-column { 55 .password-column {
50 align-items: center; 56 align-items: center;
51 display: flex; 57 display: flex;
52 flex: 2; 58 flex: 2;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 items="[[getFilteredPasswords_(savedPasswords, filter)]]" 111 items="[[getFilteredPasswords_(savedPasswords, filter)]]"
106 class="vertical-list list-with-header" 112 class="vertical-list list-with-header"
107 scroll-target="[[subpageScrollTarget]]"> 113 scroll-target="[[subpageScrollTarget]]">
108 <template> 114 <template>
109 <div class="list-item"> 115 <div class="list-item">
110 <div class="website-column no-min-width"> 116 <div class="website-column no-min-width">
111 <a id="originUrl" target="_blank" class="selectable no-min-width" 117 <a id="originUrl" target="_blank" class="selectable no-min-width"
112 href="[[item.linkUrl]]"> 118 href="[[item.linkUrl]]">
113 <span class="text-elide"> 119 <span class="text-elide">
114 [[item.loginPair.originUrl]] 120 [[item.loginPair.originUrl]]
121 <paper-tooltip position="top">[[item.linkUrl]]</paper-tooltip>
Dan Beam 2017/03/28 13:02:08 can we just set a title="" instead?
115 </span> 122 </span>
116 </a> 123 </a>
117 </div> 124 </div>
118 <div class="username-column selectable text-elide" 125 <div class="username-column selectable text-elide"
119 id="username">[[item.loginPair.username]]</div> 126 id="username">[[item.loginPair.username]]</div>
120 <div class="password-column"> 127 <div class="password-column">
121 <!-- Password type and disabled in order to match mock. --> 128 <!-- Password type and disabled in order to match mock. -->
122 <input id="password" type="password" disabled 129 <input id="password" type="password" disabled
123 value="[[getEmptyPassword_(item.numCharactersInPassword)]]"> 130 value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
124 </input> 131 </input>
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 </div> 172 </div>
166 </template> 173 </template>
167 <div id="noExceptionsLabel" class="list-item" 174 <div id="noExceptionsLabel" class="list-item"
168 hidden$="[[hasSome_(passwordExceptions)]]"> 175 hidden$="[[hasSome_(passwordExceptions)]]">
169 $i18n{noExceptionsFound} 176 $i18n{noExceptionsFound}
170 </div> 177 </div>
171 </div> 178 </div>
172 </template> 179 </template>
173 <script src="passwords_section.js"></script> 180 <script src="passwords_section.js"></script>
174 </dom-module> 181 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698