Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4057)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc
index b5073942cf1c2466f2300b95532c1f88bd419836..bcb3066e597cc74ae6154993c94d1e3013e9116f 100644
--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc
@@ -8,6 +8,7 @@
#include <stddef.h>
+#include <utility>
#include <vector>
#include "base/logging.h"
@@ -103,12 +104,13 @@ Cookie CreateCookie(const net::CanonicalCookie& canonical_cookie,
return cookie;
}
-CookieStore CreateCookieStore(Profile* profile, base::ListValue* tab_ids) {
+CookieStore CreateCookieStore(Profile* profile,
+ std::unique_ptr<base::ListValue> tab_ids) {
DCHECK(profile);
DCHECK(tab_ids);
base::DictionaryValue dict;
dict.SetString(keys::kIdKey, GetStoreIdFromProfile(profile));
- dict.Set(keys::kTabIdsKey, tab_ids);
+ dict.Set(keys::kTabIdsKey, std::move(tab_ids));
CookieStore cookie_store;
bool rv = CookieStore::Populate(dict, &cookie_store);

Powered by Google App Engine
This is Rietveld 408576698