chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Just rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/counting_policy_unittest.cc ('k') | chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc » ('j') | chrome/browser/extensions/api/proxy/proxy_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

index 1e0dd111be182557afabb2dd2f8b227d71af7c8c..c98a8b13932144759caf2bdd16fac5ea8b06db22 100644

--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

@@ -20,6 +20,7 @@

#include "base/test/simple_test_clock.h"

#include "base/test/test_timeouts.h"

#include "base/threading/thread_task_runner_handle.h"

+#include "base/values.h"

#include "build/build_config.h"

#include "chrome/browser/extensions/activity_log/activity_log.h"

#include "chrome/browser/extensions/extension_service.h"

@@ -511,8 +512,8 @@ TEST_F(FullStreamUIPolicyTest, LogWithArguments) {

extension_service_->AddExtension(extension.get());

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Set(0, new base::Value("hello"));

- args->Set(1, new base::Value("world"));

+ args->Set(0, base::MakeUnique<base::Value>("hello"));

+ args->Set(1, base::MakeUnique<base::Value>("world"));

scoped_refptr<Action> action = new Action(extension->id(),

base::Time::Now(),

Action::ACTION_API_CALL,