Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
index 93378da804c657a62c67cc5617fda586913494b3..6b07d537d453c8ef6abc7a22aa97ff0c3f727cc6 100644
--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc
+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
@@ -4,6 +4,7 @@
#include <memory>
#include <string>
+#include <utility>
#include "base/auto_reset.h"
#include "base/command_line.h"
@@ -985,10 +986,10 @@ TEST_F(HostContentSettingsMapTest, CanonicalizeExceptionsUnicodeOnly) {
base::DictionaryValue* all_settings_dictionary = update.Get();
ASSERT_TRUE(NULL != all_settings_dictionary);
- base::DictionaryValue* dummy_payload = new base::DictionaryValue;
+ auto dummy_payload = base::MakeUnique<base::DictionaryValue>();
dummy_payload->SetInteger("setting", CONTENT_SETTING_ALLOW);
all_settings_dictionary->SetWithoutPathExpansion("[*.]\xC4\x87ira.com,*",
- dummy_payload);
+ std::move(dummy_payload));
}
HostContentSettingsMapFactory::GetForProfile(&profile);
@@ -1520,10 +1521,10 @@ TEST_F(HostContentSettingsMapTest, DomainToOriginMigrationStatus) {
base::DictionaryValue* all_settings_dictionary = update.Get();
ASSERT_TRUE(NULL != all_settings_dictionary);
- base::DictionaryValue* domain_setting = new base::DictionaryValue;
+ auto domain_setting = base::MakeUnique<base::DictionaryValue>();
domain_setting->SetInteger("setting", CONTENT_SETTING_ALLOW);
all_settings_dictionary->SetWithoutPathExpansion(host_pattern_string + ",*",
- domain_setting);
+ std::move(domain_setting));
}
const base::DictionaryValue* all_settings_dictionary =

Powered by Google App Engine
This is Rietveld 408576698