Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc
diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
index 1916e307c259080188c33a1c7abeca14df517d1d..7bf2b823f8f7b3580876cbdb49bf49733cd6eb7a 100644
--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
@@ -5,6 +5,7 @@
#include <stddef.h>
jdoerrie 2017/04/06 14:25:51 #include <utility>
vabr (Chromium) 2017/04/07 20:40:41 Done.
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/values.h"
#include "build/build_config.h"
@@ -109,10 +110,10 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {
manifest.SetString(keys::kName, "Protected");
manifest.SetString(keys::kVersion, "1");
manifest.SetString(keys::kLaunchWebURL, "http://explicit/protected/start");
- base::ListValue* list = new base::ListValue();
+ auto list = base::MakeUnique<base::ListValue>();
list->AppendString("http://explicit/protected");
list->AppendString("*://*.wildcards/protected");
- manifest.Set(keys::kWebURLs, list);
+ manifest.Set(keys::kWebURLs, std::move(list));
std::string error;
scoped_refptr<Extension> protected_app = Extension::Create(
path, Manifest::INVALID_LOCATION, manifest,
@@ -131,13 +132,13 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {
manifest.SetString(keys::kName, "Unlimited");
manifest.SetString(keys::kVersion, "1");
manifest.SetString(keys::kLaunchWebURL, "http://explicit/unlimited/start");
- base::ListValue* list = new base::ListValue();
+ auto list = base::MakeUnique<base::ListValue>();
list->AppendString("unlimitedStorage");
- manifest.Set(keys::kPermissions, list);
- list = new base::ListValue();
+ manifest.Set(keys::kPermissions, std::move(list));
+ list = base::MakeUnique<base::ListValue>();
list->AppendString("http://explicit/unlimited");
list->AppendString("*://*.wildcards/unlimited");
- manifest.Set(keys::kWebURLs, list);
+ manifest.Set(keys::kWebURLs, std::move(list));
std::string error;
scoped_refptr<Extension> unlimited_app = Extension::Create(
path, Manifest::INVALID_LOCATION, manifest,

Powered by Google App Engine
This is Rietveld 408576698