chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/api/preference/chrome_direct_setting.cc ('k') | chrome/browser/extensions/api/preference/preference_api.h » ('j') | chrome/browser/extensions/api/storage/settings_sync_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

index 26a2c9fa991a9b33bd7bbf87666be51cd61b336b..5bf1d8f7a028bbe0a7bc631fb783cb0cc0214a53 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

@@ -137,7 +137,7 @@ void ChromeDirectSettingAPI::OnPrefChanged(

const base::Value* value = preference->GetValue();

std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);

- result->Set(preference_api_constants::kValue, value->DeepCopy());

+ result->Set(preference_api_constants::kValue, value->CreateDeepCopy());

base::ListValue args;

args.Append(std::move(result));