chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc ('K') | « chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc ('k') | chrome/browser/extensions/api/preference/chrome_direct_setting.cc » ('j') | chrome/browser/extensions/api/storage/settings_sync_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

index 2a8a5a44605360b42d039ccfa5375aad7f2fb77a..341df18ff3aab6f20ca217f77208e72eb78bfbe9 100644

--- a/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

@@ -5,6 +5,7 @@

#include <cryptohi.h>

#include <memory>

+#include <utility>

#include "base/json/json_writer.h"

#include "base/macros.h"

@@ -197,7 +198,7 @@ class PlatformKeysTest : public ExtensionApiTest {

cert1_key_permission->SetBooleanWithoutPathExpansion(

"allowCorporateKeyUsage", true);

key_permissions_policy.SetWithoutPathExpansion(

- extension_->id(), cert1_key_permission.release());

+ extension_->id(), std::move(cert1_key_permission));

}

std::string key_permissions_policy_str;