chrome/browser/extensions/api/commands/command_service_browsertest.cc - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service_browsertest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/commands/command_service.cc ('K') | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/api/cookies/cookies_api.cc » ('j') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/commands/command_service_browsertest.cc

diff --git a/chrome/browser/extensions/api/commands/command_service_browsertest.cc b/chrome/browser/extensions/api/commands/command_service_browsertest.cc

index 0f69acbf453a681720e877646877a021884aa115..347f0a7b50c58f3fdcb43d10b8dbf875d65f3f7d 100644

--- a/chrome/browser/extensions/api/commands/command_service_browsertest.cc

+++ b/chrome/browser/extensions/api/commands/command_service_browsertest.cc

@@ -110,11 +110,11 @@ IN_PROC_BROWSER_TEST_F(CommandServiceTest,

// another platform.

std::string anotherPlatformKey = GetAnotherCommandPlatform() + ":Alt+G";

const char kNamedCommandName[] = "toggle-feature";

- base::DictionaryValue* keybinding = new base::DictionaryValue();

+ auto keybinding = base::MakeUnique<base::DictionaryValue>();

keybinding->SetString("extension", extension->id());

keybinding->SetString("command_name", kNamedCommandName);

keybinding->SetBoolean("global", false);

- bindings->Set(anotherPlatformKey, keybinding);

+ bindings->Set(anotherPlatformKey, std::move(keybinding));

CommandService* command_service = CommandService::Get(browser()->profile());

command_service->RemoveKeybindingPrefs(extension->id(), kNamedCommandName);